Conversation
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 5 5
Branches 1 1
=====================================
Hits 5 5
Continue to review full report at Codecov.
|
|
Hey @sjparsons, thanks for this. It definitely sounds like a useful feature, thanks! I will review it quite soon as I am gonna be doing some updates to this lib. 👍 |
|
Hey @sjparsons, so I have updated this library to use the latest version of e.g. class Foo extends Component {
bootstrap() {
console.log(this.context.myBootstrapSetting)
}
render() {
return <div>foo</div>
}
}
bootstrapper(<Foo />, null, { myBootstrapSetting: 'what_ever_you_need' })
.then(() => console.log('done'))As you can see it's a new third parameter to the bootstrapper. I think it would be best to keep the secondary What do you think? You may have noticed I am using |
Hi, it would be useful to be able to pass the options object in the
asyncBootstrapperdown into the individualasyncBootstrapcallbacks.Here's an example.
This PR makes that change and also adds a test to assert this funtionality.